Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-395: make the retry context aware of the policies that have a maxi… #396

Merged
merged 2 commits into from
Nov 17, 2023
Merged

GH-395: make the retry context aware of the policies that have a maxi… #396

merged 2 commits into from
Nov 17, 2023

Conversation

e-ivaldi
Copy link
Contributor

@e-ivaldi e-ivaldi commented Oct 31, 2023 •
edited
Loading

No description provided.

@e-ivaldi e-ivaldi mentioned this pull request Oct 31, 2023
Closed
@artembilan artembilan added this to the 2.0.5 milestone Nov 6, 2023
artembilan
artembilan approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection on this.
I like the code as it is right now in the PR without any further changes.
Thanks

@e-ivaldi
Copy link
Contributor Author

e-ivaldi commented Nov 7, 2023

I have no objection on this. I like the code as it is right now in the PR without any further changes. Thanks

Glad to hear that @artembilan, thank you

artembilan
artembilan requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your name to the @author list of the affected classes, please.

@e-ivaldi
Copy link
Contributor Author

Thanks, done. Have added myself as an author to all classes I modified that already had an author list.

@e-ivaldi e-ivaldi force-pushed the GH-395-retry-context-max-attempts-aware branch 2 times, most recently from d309296 to 37300f9 Compare November 17, 2023 18:45
artembilan
artembilan requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a conflict in your branch against the latest main:

Conflicting files
src/test/java/org/springframework/retry/annotation/EnableRetryTests.java

Please, consider to rebase, fix it and push.

Thanks

@e-ivaldi e-ivaldi force-pushed the GH-395-retry-context-max-attempts-aware branch from 37300f9 to 5d87091 Compare November 17, 2023 18:54
@e-ivaldi
Copy link
Contributor Author

e-ivaldi commented Nov 17, 2023 •
edited
Loading

Oh yes, I noticed immediately after pushing the update, rebased and fixed the conflicts, thank you.

@artembilan artembilan removed this from the 2.0.5 milestone Nov 17, 2023
@artembilan artembilan merged commit 7516219 into spring-projects:main Nov 17, 2023
2 checks passed
@artembilan
Copy link
Member

@e-ivaldi ,

thank you for contribution; looking forward for more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@e-ivaldi @artembilan