Add Test

Issue gh-13660
spring-projects · Oct 30, 2023 · ed6ff67 · ed6ff67
1 parent 4d6ff49
commit ed6ff67
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java b/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java
@@ -141,7 +141,7 @@ public void doFilter(ServletRequest request, ServletResponse response) throws IO
 
 	static final class ObservationFilter implements Filter {
 
-		private static final Map<String, String> OBSERVATION_NAMES = new HashMap<>();
+		static final Map<String, String> OBSERVATION_NAMES = new HashMap<>();
 
 		static {
 			OBSERVATION_NAMES.put("DisableEncodeUrlFilter", "session.urlencoding");

diff --git a/web/src/test/java/org/springframework/security/web/ObservationFilterChainDecoratorTests.java b/web/src/test/java/org/springframework/security/web/ObservationFilterChainDecoratorTests.java
@@ -150,6 +150,13 @@ void decorateFiltersWhenCompletesThenHasSpringSecurityReachedFilterNameTag(Filte
 			.isEqualTo(expectedFilterNameTag);
 	}
 
+	// gh-13660
+	@Test
+	void observationNamesDoNotContainDashes() {
+		ObservationFilterChainDecorator.ObservationFilter.OBSERVATION_NAMES.values()
+			.forEach((name) -> assertThat(name).doesNotContain("-"));
+	}
+
 	static Stream<Arguments> decorateFiltersWhenCompletesThenHasSpringSecurityReachedFilterNameTag() {
 		Filter filterWithName = new BasicAuthenticationFilter();