Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Samples should run against the current artifacts #10344

Closed
marcusdacoregio opened this issue Oct 5, 2021 · 0 comments · Fixed by #10783
Closed

Check Samples should run against the current artifacts #10344

marcusdacoregio opened this issue Oct 5, 2021 · 0 comments · Fixed by #10783
Assignees
@marcusdacoregio
Labels
in: build An issue in the build status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.8.0-M1

Comments

@marcusdacoregio
Copy link
Contributor

When checking the samples we are testing against the artifacts that are already deployed. Instead we should run against the artifacts that we about to deploy
@marcusdacoregio marcusdacoregio added in: build An issue in the build type: enhancement A general enhancement labels Oct 5, 2021
@marcusdacoregio marcusdacoregio self-assigned this Oct 5, 2021
marcusdacoregio added a commit to marcusdacoregio/spring-security-samples that referenced this issue Jan 21, 2022
@marcusdacoregio
Add init script to be used in Spring Security CI
83ca130 
Issue spring-projects/spring-security#10344
marcusdacoregio added a commit to marcusdacoregio/spring-security-samples that referenced this issue Jan 21, 2022
@marcusdacoregio
Add init script to be used in Spring Security CI
41cc8e9 
Issue spring-projects/spring-security#10344
marcusdacoregio added a commit to marcusdacoregio/spring-security-samples that referenced this issue Jan 21, 2022
@marcusdacoregio
Add init script to be used in Spring Security CI
e5e1772 
Issue spring-projects/spring-security#10344
marcusdacoregio added a commit to marcusdacoregio/spring-security-samples that referenced this issue Jan 24, 2022
@marcusdacoregio
Add init script to be used in Spring Security CI
98d5daa 
Issue spring-projects/spring-security#10344
This was referenced Jan 26, 2022
Merged
Merged
marcusdacoregio added a commit to marcusdacoregio/spring-security-samples that referenced this issue May 11, 2022
@marcusdacoregio
Add init script to be used in Spring Security CI
8716240 
Issue spring-projects/spring-security#10344
marcusdacoregio added a commit to spring-projects/spring-security-samples that referenced this issue May 11, 2022
@marcusdacoregio
Add init script to be used in Spring Security CI
554f196 
Issue spring-projects/spring-security#10344
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue May 11, 2022
@marcusdacoregio
Add initScripts and projectProperties to IncludeCheckRemotePlugin
3b96a0b 
Issue spring-projectsgh-10344
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue May 11, 2022
@marcusdacoregio
Use properties in the checkSamples job
1fc0434 
Issue spring-projectsgh-10344
marcusdacoregio added a commit that referenced this issue May 11, 2022
@marcusdacoregio
Add initScripts and projectProperties to IncludeCheckRemotePlugin
cddffa4 
Issue gh-10344
marcusdacoregio added a commit that referenced this issue May 11, 2022
@marcusdacoregio
Use properties in the checkSamples job
0137f94 
Issue gh-10344
marcusdacoregio added a commit to spring-projects/spring-security-samples that referenced this issue May 11, 2022
@marcusdacoregio
Add init script to be used in Spring Security CI
b67e18f 
Issue spring-projects/spring-security#10344
marcusdacoregio added a commit to spring-projects/spring-security-samples that referenced this issue May 11, 2022
@marcusdacoregio
Add init script to be used in Spring Security CI
bb7b822 
Issue spring-projects/spring-security#10344
marcusdacoregio added a commit to spring-projects/spring-security-samples that referenced this issue May 11, 2022
@marcusdacoregio
Add init script to be used in Spring Security CI
83225ad 
Issue spring-projects/spring-security#10344
marcusdacoregio added a commit that referenced this issue May 12, 2022
@marcusdacoregio
Add initScripts and projectProperties to IncludeCheckRemotePlugin
723648a 
Issue gh-10344
marcusdacoregio added a commit that referenced this issue May 12, 2022
@marcusdacoregio
Use properties in the checkSamples job
b544159 
Issue gh-10344
@marcusdacoregio marcusdacoregio added this to the 5.8.0-M1 milestone May 12, 2022
@marcusdacoregio marcusdacoregio added the status: backported An issue that has been backported to maintenance branches label May 12, 2022
@marcusdacoregio marcusdacoregio changed the title Check Samples should be run against the current artifacts Check Samples should run against the current artifacts May 12, 2022
marcusdacoregio added a commit that referenced this issue May 12, 2022
@marcusdacoregio
Add initScripts and projectProperties to IncludeCheckRemotePlugin
34f280a 
Issue gh-10344
marcusdacoregio added a commit that referenced this issue May 12, 2022
@marcusdacoregio
Use properties in the checkSamples job
991d5c8 
Issue gh-10344
marcusdacoregio added a commit that referenced this issue May 12, 2022
@marcusdacoregio
Add initScripts and projectProperties to IncludeCheckRemotePlugin
330f0f0 
Issue gh-10344
marcusdacoregio added a commit that referenced this issue May 12, 2022
@marcusdacoregio
Use properties in the checkSamples job
44e672d 
Issue gh-10344
marcusdacoregio added a commit to spring-projects/spring-security-samples that referenced this issue Feb 23, 2023
@marcusdacoregio
Add init script to be used in Spring Security CI
60b1f3b 
Issue spring-projects/spring-security#10344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: build An issue in the build status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.8.0-M1
Development

Successfully merging a pull request may close this issue.

checkSamples must consider current artifacts marcusdacoregio/spring-security
1 participant
@marcusdacoregio