Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OAuth2ResourceServerConfigurer member variable using Java 9+ feature #10695

Closed
marcusdacoregio opened this issue Jan 11, 2022 · 2 comments · Fixed by #10817
Closed

Fix OAuth2ResourceServerConfigurer member variable using Java 9+ feature #10695

marcusdacoregio opened this issue Jan 11, 2022 · 2 comments · Fixed by #10817
Assignees
@marcusdacoregio
Labels
in: build An issue in the build status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.8.0-M1

Comments

@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Jan 11, 2022 •
edited

The code in the 5.7.x branch is requiring JDK 11

spring-security/config/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurer.java

Line 162 in f04cd64

new LinkedHashMap<>(Map.of(CsrfException.class, new AccessDeniedHandlerImpl())),

We should fix this and the build should fail if using a language feature that is not compatible with JDK 8.
@marcusdacoregio marcusdacoregio added in: build An issue in the build type: bug A general bug labels Jan 11, 2022
@marcusdacoregio marcusdacoregio added this to the 5.7.0-M1 milestone Jan 11, 2022
@marcusdacoregio marcusdacoregio self-assigned this Jan 11, 2022
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jan 11, 2022
@marcusdacoregio
Make source code compatible with JDK 8
60ed360 
Closes spring-projectsgh-10695
@marcusdacoregio
Copy link
Contributor Author

Fixed via 60ed360

marcusdacoregio added a commit that referenced this issue Jan 12, 2022
@marcusdacoregio
Make source code compatible with JDK 8
e1cb375 
Closes gh-10695
marcusdacoregio added a commit that referenced this issue Jan 12, 2022
@marcusdacoregio
Make source code compatible with JDK 8
a763382 
Closes gh-10695
@marcusdacoregio marcusdacoregio added for: backport-to-5.6.x Designates an issue for backport to 5.6.x for: backport-to-5.5.x Designates an issue for backport to 5.5.x labels Jan 13, 2022
@marcusdacoregio marcusdacoregio changed the title Source code is not compatible with JDK 8 Make source code compatible with JDK 8 Jan 13, 2022
This was referenced Jan 13, 2022
Closed
Closed
@marcusdacoregio marcusdacoregio added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.5.x Designates an issue for backport to 5.5.x for: backport-to-5.6.x Designates an issue for backport to 5.6.x labels Jan 13, 2022
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jan 27, 2022
@marcusdacoregio
Fix member variable using JDK 9 feature
e942dfb 
Because we should compile using JDK 8, we cannot use JDK 8+ features in member variables since they are executed at compile time

Issue spring-projectsgh-10695
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jan 27, 2022
@marcusdacoregio
Add checkSamples using JDK 8
da1cadb 
Issue spring-projectsgh-10695
@marcusdacoregio
Copy link
Contributor Author

marcusdacoregio commented Feb 2, 2022 •
edited

Reopening this because the solution was a workaround to enable teams from moving forward.

@marcusdacoregio marcusdacoregio modified the milestones: 5.7.0-M1, 5.7.0-M2 Feb 2, 2022
@marcusdacoregio marcusdacoregio changed the title Make source code compatible with JDK 8 Fix OAuth2ResourceServerConfigurer member variable using Java 9+ feature Feb 2, 2022
@marcusdacoregio marcusdacoregio mentioned this issue Feb 8, 2022
Merged
@marcusdacoregio marcusdacoregio linked a pull request Feb 8, 2022 that will close this issue
Build modules using Java 8 #10817
Merged
@marcusdacoregio marcusdacoregio modified the milestones: 5.7.0-M2, 5.7.0-M3 Feb 21, 2022
@marcusdacoregio marcusdacoregio modified the milestones: 5.7.0-M3, 5.7.0-RC1 Mar 21, 2022
@rwinch rwinch modified the milestones: 5.7.0-RC1, 5.8.x Apr 18, 2022
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jun 2, 2022
@marcusdacoregio
Fix member variable using Java 9+ feature
9a72461 
This causes compile errors when trying to build using JDK 8

Issue spring-projectsgh-10695
marcusdacoregio added a commit that referenced this issue Jun 2, 2022
@marcusdacoregio
Fix member variable using Java 9+ feature
ccb1f68 
This causes compile errors when trying to build using JDK 8

Issue gh-10695
@marcusdacoregio marcusdacoregio modified the milestones: 5.8.x, 5.8.0-M1 Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: build An issue in the build status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.8.0-M1
Development

Successfully merging a pull request may close this issue.

Build modules using Java 8 marcusdacoregio/spring-security
2 participants
@rwinch @marcusdacoregio