Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build modules using Java 8 #10816

Closed
marcusdacoregio opened this issue Feb 8, 2022 · 1 comment · Fixed by #10817
Closed

Build modules using Java 8 #10816

marcusdacoregio opened this issue Feb 8, 2022 · 1 comment · Fixed by #10817
Assignees
Labels
in: build An issue in the build type: enhancement A general enhancement
Milestone

Comments

@marcusdacoregio
Copy link
Contributor

We should use Java 8 to build our modules since we have to be Java 8 compatible.

As of now, there is no way to know if we added a Java 9+ language feature.

We might use Gradle Toolchain in order to specify a Java version to run the tasks

@marcusdacoregio marcusdacoregio added in: build An issue in the build type: enhancement A general enhancement labels Feb 8, 2022
@marcusdacoregio marcusdacoregio added this to the 5.7.x milestone Feb 8, 2022
@marcusdacoregio marcusdacoregio self-assigned this Feb 8, 2022
@marcusdacoregio marcusdacoregio linked a pull request Feb 8, 2022 that will close this issue
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jun 2, 2022
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jun 2, 2022
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jun 2, 2022
Because the OpenSAML4 classes are compiled using Java 11, we have to rely on reflection to instante those classes since the config module should be compatible with Java 8

Issue spring-projectsgh-10816
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jun 2, 2022
marcusdacoregio added a commit that referenced this issue Jun 2, 2022
marcusdacoregio added a commit that referenced this issue Jun 2, 2022
Because the OpenSAML4 classes are compiled using Java 11, we have to rely on reflection to instante those classes since the config module should be compatible with Java 8

Issue gh-10816
@marcusdacoregio
Copy link
Contributor Author

Fixed via #10817

@marcusdacoregio marcusdacoregio modified the milestones: 5.7.x, 5.8.0-M1 Jun 2, 2022
marcusdacoregio added a commit that referenced this issue Jun 3, 2022
This commit makes the check task depend on the saml2Tests task.
The test task was also configured to run after saml2Tests, to make sure that the
compileTestJava runs after the compileSaml2TestJava

Issue gh-10816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant