Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relyingPartyRegistrationId to AbstractSaml2AuthenticationRequest #11195

Closed
jzheaux opened this issue May 10, 2022 · 1 comment
Closed

Add relyingPartyRegistrationId to AbstractSaml2AuthenticationRequest #11195

jzheaux opened this issue May 10, 2022 · 1 comment
Labels
in: saml2 An issue in SAML2 modules status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented May 10, 2022

It would be nice if implementations of AbstractSaml2AuthenticationRequest stored the relyingPartyRegistrationId.

One benefit is it introduces the ability to look up the registration id during login. Currently, the only way to do this is by path or by implementing a custom RelyingPartyRegistrationResolver.

The needed changes are as follows:

  • Adding the registration id as a property in AbstractSaml2AuthenticationRequest (see Saml2LogoutRequest and Saml2LogoutResponse for examples).
  • Set that property in the withRelyingPartyRegistration static methods
  • Read the property in Saml2AuthenticationTokenConverter to determine the registration id, passing that to the configured relyingPartyRegistrationResolver

Note that these changes should be made in such a way that receiving an unsolicited SAML response still works (e.g. there is no stored AuthnRequest).

@jzheaux jzheaux added type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels May 10, 2022
@jzheaux jzheaux added this to the 5.8.0-M1 milestone May 10, 2022
@jzheaux jzheaux added the in: saml2 An issue in SAML2 modules label May 10, 2022
@ugrave
Copy link
Contributor

ugrave commented May 12, 2022

Created a PR #11198 which adds the registration id to the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants