Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHubMilestoneApiTests due_on Should Use LocalDate #11706

Closed
rwinch opened this issue Aug 15, 2022 · 0 comments
Closed

GitHubMilestoneApiTests due_on Should Use LocalDate #11706

rwinch opened this issue Aug 15, 2022 · 0 comments
Assignees
@rwinch
Labels
in: build An issue in the build status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.8.0-M3

Comments

@rwinch
Copy link
Member

rwinch commented Aug 15, 2022

GitHubMilestoneApiTests uses Instant.now() for due_on. Since Instant.now() is UTC time based, isMilestoneDueTodayWhenDueTodayThenTrue fails when the computer that runs the test is not the same day as it is in UTC time.

To fix it, due_on should be set to an Instant based upon the timezone of the current computer.
@rwinch rwinch added in: build An issue in the build type: bug A general bug labels Aug 15, 2022
@rwinch rwinch added this to the 5.8.0-M3 milestone Aug 15, 2022
@rwinch rwinch self-assigned this Aug 15, 2022
rwinch added a commit that referenced this issue Aug 15, 2022
@rwinch
GitHubMilestoneApiTests due_on Uses LocalDate
4473c3f 
`GitHubMilestoneApiTests` uses `Instant.now()` for `due_on`. Since
`Instant.now()` is UTC time based,
`isMilestoneDueTodayWhenDueTodayThenTrue` fails when the computer that runs
the test is not the same day as it is in UTC time.

To fix it, `due_on` should be set to an `Instant` based upon the timezone
of the current computer.

Closes gh-11706
@rwinch rwinch closed this as completed in c7b39ee Aug 15, 2022
rwinch added a commit that referenced this issue Aug 15, 2022
@rwinch
GitHubMilestoneApiTests due_on Uses LocalDate
d8ae2c8 
`GitHubMilestoneApiTests` uses `Instant.now()` for `due_on`. Since
`Instant.now()` is UTC time based,
`isMilestoneDueTodayWhenDueTodayThenTrue` fails when the computer that runs
the test is not the same day as it is in UTC time.

To fix it, `due_on` should be set to an `Instant` based upon the timezone
of the current computer.

Closes gh-11706
@github-actions github-actions bot added the status: backported An issue that has been backported to maintenance branches label Aug 15, 2022
@github-actions github-actions bot mentioned this issue Aug 15, 2022
Closed
rwinch added a commit that referenced this issue Aug 15, 2022
@rwinch
GitHubMilestoneApiTests due_on Uses LocalDate
f33d725 
`GitHubMilestoneApiTests` uses `Instant.now()` for `due_on`. Since
`Instant.now()` is UTC time based,
`isMilestoneDueTodayWhenDueTodayThenTrue` fails when the computer that runs
the test is not the same day as it is in UTC time.

To fix it, `due_on` should be set to an `Instant` based upon the timezone
of the current computer.

Closes gh-11706
@github-actions github-actions bot mentioned this issue Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: build An issue in the build status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.8.0-M3
Development

No branches or pull requests
1 participant
@rwinch