Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MvcRequestMatcher by default if Spring MVC is present #11899

Closed
marcusdacoregio opened this issue Sep 26, 2022 · 0 comments · Fixed by #11950
Closed

Use MvcRequestMatcher by default if Spring MVC is present #11899

marcusdacoregio opened this issue Sep 26, 2022 · 0 comments · Fixed by #11950
Assignees
@marcusdacoregio
Labels
in: config An issue in spring-security-config type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Milestone
6.0.0-RC1

Comments

@marcusdacoregio
Copy link
Contributor

In some places, like XML configuration (AuthorizationFilterParser, FilterChainBeanDefinitionParser, MatcherType), the default RequestMatcher implementation is AntPathRequestMatcher. We should switch the default to MvcRequestMatcher if Spring MVC is on the classpath.

See:
@marcusdacoregio marcusdacoregio added in: config An issue in spring-security-config type: enhancement A general enhancement labels Sep 26, 2022
@marcusdacoregio marcusdacoregio added this to the 6.0.0-RC1 milestone Sep 26, 2022
@marcusdacoregio marcusdacoregio self-assigned this Sep 26, 2022
@marcusdacoregio marcusdacoregio added the type: breaks-passivity A change that breaks passivity with the previous release label Oct 4, 2022
@marcusdacoregio marcusdacoregio mentioned this issue Oct 4, 2022
Merged
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Oct 6, 2022
@marcusdacoregio
Use MvcRequestMatcher by default if Spring MVC is present
4e62e3c 
Closes spring-projectsgh-11899
marcusdacoregio added a commit that referenced this issue Oct 6, 2022
@marcusdacoregio
Use MvcRequestMatcher by default if Spring MVC is present
c4d23f2 
Closes gh-11899
@marcusdacoregio marcusdacoregio mentioned this issue Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: config An issue in spring-security-config type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC1
Development

Successfully merging a pull request may close this issue.

Use MvcRequestMatcher by default if Spring MVC is present marcusdacoregio/spring-security
1 participant
@marcusdacoregio