Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document relationship between registrationId, EntityID, and resolving a relying party #12764

Closed
jzheaux opened this issue Feb 22, 2023 · 3 comments
Assignees
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Feb 22, 2023

Based on #12664, the documentation around SAML 2.0 URIs could be clearer.

Specifically, it should be clearer when and why setting a registrationId or configuring relying party lookup is important. One reason that it is important is that RelyingPartyRegistrations defaults the registrationId to be the asserting party's entity id, which cannot be placed in the path of URIs like /authenticate/{registrationId}. Either the relying party lookup strategy needs or the registration id needs to change.

@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement labels Feb 22, 2023
@jzheaux jzheaux self-assigned this Feb 22, 2023
@stnor
Copy link

stnor commented Feb 22, 2023

Regarding this, it's not practical to "invent" new id:s for 200 IdPs in a large federation. The business key in the metadata is the entityId, right?

Based on your comment in #12664, I guess you're saying that the id could be generated? Keep in mind that I need to provide a persistent url for the customers using one particular IdP so it cannot change over time.

@jzheaux
Copy link
Contributor Author

jzheaux commented Feb 22, 2023

@stnor thanks for the feedback, but I think this strays from the focus of this issue which is to improve the documentation.

I'm very happy about your interest in migrating to Spring Security, and I want to help. So far, I realize that I've been responding to your thoughts and questions wherever they are appearing. Going forward, please feel free to open a ticket if you have an enhancement you want to discuss or a bug you want fixed. Otherwise, you can engage me and the team over chat on Gitter and/or StackOverflow. That will help keep each ticket focused on its primary task.

jzheaux added a commit that referenced this issue Feb 28, 2023
@jzheaux
Copy link
Contributor Author

jzheaux commented Feb 28, 2023

Also note that as part of the documentation improvement here, spring-projects/spring-security-samples#122 was added.

@jzheaux jzheaux added this to the 5.7.8 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants