Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AuthenticationPrincipal migration more obvious #3771

Closed
rwinch opened this issue Mar 25, 2016 · 2 comments · Fixed by #3821
Closed

Make AuthenticationPrincipal migration more obvious #3771

rwinch opened this issue Mar 25, 2016 · 2 comments · Fixed by #3821
Assignees
@jgrandja
Labels
in: docs An issue in Documentation or samples
Milestone
4.1.0 RC2

Comments

@rwinch
Copy link
Member

rwinch commented Mar 25, 2016

It seems like there are a number of people having difficulty migrating to the new AuthenticationPrincipal. We should make it more obvious that org.springframework.security.web.method.annotation.AuthenticationPrincipalArgum‌​entResolver should be used.

Ideas for where this can be documented

  • Migration Guide
  • Deprecation notice
  • Javadoc of AuthenticationPrincipal
@rwinch rwinch added the in: docs An issue in Documentation or samples label Mar 25, 2016
@rwinch rwinch added this to the 4.1.0 milestone Mar 25, 2016
@mesutdogan
Copy link

I think It should be on Migration Guide.

@rwinch
Copy link
Member Author

rwinch commented Mar 28, 2016

@mesutdogan Thanks for the feedback. We will be sure to include information on the migration guide.

@jgrandja jgrandja self-assigned this Apr 12, 2016
@jgrandja jgrandja reopened this Apr 13, 2016
jgrandja added a commit to jgrandja/spring-security that referenced this issue Apr 15, 2016
@jgrandja
Correction to xml configuration for AuthenticationPrincipalArgumentRe…
da4213e 
…solver in reference doc.

Fixes spring-projectsgh-3771
@jgrandja jgrandja mentioned this issue Apr 15, 2016
Merged
1 task
rwinch pushed a commit that referenced this issue Apr 15, 2016
@jgrandja @rwinch
Fix AuthenticationPrincipalArgumentResolver xml doc
81c9fa8 
Fixes gh-3771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: docs An issue in Documentation or samples
Projects
None yet
Milestone
4.1.0 RC2
Development

Successfully merging a pull request may close this issue.

Correction to xml configuration for AuthenticationPrincipalArgumentResolver jgrandja/spring-security
3 participants
@rwinch @mesutdogan @jgrandja