Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring 5 Compatabilty #4080

Closed
rwinch opened this issue Oct 4, 2016 · 0 comments
Closed

Spring 5 Compatabilty #4080

rwinch opened this issue Oct 4, 2016 · 0 comments
Assignees
@rwinch
Labels
in: build An issue in the build type: enhancement A general enhancement
Milestone
4.2.0 RC1

Comments

@rwinch
Copy link
Member

rwinch commented Oct 4, 2016

Support Spring 5.x and Spring 4.x. This is important for ensuring users can gradually migrate.
@rwinch rwinch added in: build An issue in the build type: enhancement A general enhancement labels Oct 4, 2016
@rwinch rwinch added this to the 4.2.0 RC1 milestone Oct 4, 2016
@rwinch rwinch self-assigned this Oct 4, 2016
rwinch pushed a commit that referenced this issue Oct 17, 2016
Version bumps for Spring 5
08c1f50 
Issue gh-4080
rwinch pushed a commit that referenced this issue Oct 17, 2016
XML ref to bean
1222fc5 
Spring 5 removes ref XML attribute in favor of bean XML attribute. This
commit updates all the samples and tests to use bean instead of ref.

Issue gh-4080
rwinch pushed a commit that referenced this issue Oct 17, 2016
Update itest/web to use Servelt 3.1
c1e9140 
Previously itest/web used Servlet 2.5 which Spring 5 is not
compatabile with. This commit removes unnecessary tests (ones that
were already covered) and converts the remaining tests to MockMvc
using the provided servlet version.

Issue gh-4080
rwinch pushed a commit that referenced this issue Oct 17, 2016
Update to Thymeleaf 3.0.2 and remove tiles
5e35e37 
Spring 5 removed support for Tiles 2 and Thymeleaf does not support
Tiles 3 yet. This commit updates to Thymeleaf 3.0.2 and uses
Thymeleaf's build in layout support.

Issue gh-4080
rwinch pushed a commit that referenced this issue Oct 17, 2016
Remove TheController from Bean
8a7ac39 
It is already picked up with classpath scanning

Issue gh-4080
rwinch pushed a commit that referenced this issue Oct 17, 2016
Remove MatcherAssertionErrors
2c99cd3 
Spring 5 removes MatcherAssertionErrors. We should not have been using
this class anyways.

This commit updates to using assertj in favor of MatcherAssertionErrors.

Issue gh-4080
rwinch pushed a commit that referenced this issue Oct 17, 2016
Fix deprecations
17cfd47 
Issue gh-4080
rwinch pushed a commit that referenced this issue Oct 17, 2016
Create RedirectMatcher
52c6e3c 
This commit creates RedirectMatcher for binary backward compatability with
Spring 4.3.x and Spring 5 to ensure that the Spring IO tests pass.

Issue gh-4080
rwinch pushed a commit that referenced this issue Oct 17, 2016
Polish Deprecations
6a3a5f7 
Issue gh-4080
@rwinch rwinch closed this as completed Oct 18, 2016
@rwinch rwinch mentioned this issue Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Milestone
4.2.0 RC1
Development

No branches or pull requests
1 participant
@rwinch