Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring 5 Compatabilty #4080

Closed
rwinch opened this issue Oct 4, 2016 · 0 comments

Comments

@rwinch
Copy link
Member

commented Oct 4, 2016

Support Spring 5.x and Spring 4.x. This is important for ensuring users can gradually migrate.

@rwinch rwinch added this to the 4.2.0 RC1 milestone Oct 4, 2016
@rwinch rwinch self-assigned this Oct 4, 2016
rwinch added a commit that referenced this issue Oct 17, 2016
rwinch added a commit that referenced this issue Oct 17, 2016
Spring 5 removes ref XML attribute in favor of bean XML attribute. This
commit updates all the samples and tests to use bean instead of ref.

Issue gh-4080
rwinch added a commit that referenced this issue Oct 17, 2016
Previously itest/web used Servlet 2.5 which Spring 5 is not
compatabile with. This commit removes unnecessary tests (ones that
were already covered) and converts the remaining tests to MockMvc
using the provided servlet version.

Issue gh-4080
rwinch added a commit that referenced this issue Oct 17, 2016
Spring 5 removed support for Tiles 2 and Thymeleaf does not support
Tiles 3 yet. This commit updates to Thymeleaf 3.0.2 and uses
Thymeleaf's build in layout support.

Issue gh-4080
rwinch added a commit that referenced this issue Oct 17, 2016
It is already picked up with classpath scanning

Issue gh-4080
rwinch added a commit that referenced this issue Oct 17, 2016
Spring 5 removes MatcherAssertionErrors. We should not have been using
this class anyways.

This commit updates to using assertj in favor of MatcherAssertionErrors.

Issue gh-4080
rwinch added a commit that referenced this issue Oct 17, 2016
rwinch added a commit that referenced this issue Oct 17, 2016
This commit creates RedirectMatcher for binary backward compatability with
Spring 4.3.x and Spring 5 to ensure that the Spring IO tests pass.

Issue gh-4080
rwinch added a commit that referenced this issue Oct 17, 2016
@rwinch rwinch closed this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.