Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with 5.0 snapshots' poms #4308

Closed
wilkinsona opened this issue Apr 22, 2017 · 2 comments
Closed

Problems with 5.0 snapshots' poms #4308

wilkinsona opened this issue Apr 22, 2017 · 2 comments
Assignees
Labels
in: build An issue in the build type: bug A general bug
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Apr 22, 2017

Summary

The poms for the latest 5.0 snapshots have a few problems:

  • They do not include any optional dependencies
  • They include test dependencies
  • They import platform-bom in their dependency management
  • commons-logging is a required dependency

Actual Behavior

N/A

Expected Behavior

The poms for 5.0.0 snapshots are similar to those for 4.2.2 in that they have none of the 4 problems described above.

Configuration

N/A

Version

5.0.0.BUILD-SNAPSHOT, specifically 5.0.0.BUILD-20170424.000033-75

Sample

N/A

@wilkinsona wilkinsona changed the title 5.0 snapshots poms do not include optional dependencies but do include test dependencies Problems with 5.0 snapshots poms Apr 24, 2017
@wilkinsona wilkinsona changed the title Problems with 5.0 snapshots poms Problems with 5.0 snapshots' poms Apr 24, 2017
@wilkinsona
Copy link
Member Author

wilkinsona commented Apr 24, 2017

The presence of commons-logging is the most problematic in the short term. It's breaking Spring Boot's build as it is configured to fail if a starter pulls commons-logging in transitively.

The lack of optional dependencies is also breaking the Platform's build as some of Spring Security's optional dependencies that are included in the Platform's bom are now being detected as redundant.

rwinch added a commit that referenced this issue Apr 25, 2017
@rwinch rwinch self-assigned this Apr 25, 2017
@rwinch rwinch added type: bug A general bug in: build An issue in the build labels Apr 25, 2017
@rwinch rwinch added this to the 5.0.0.M1 milestone Apr 25, 2017
@rwinch
Copy link
Member

rwinch commented Apr 25, 2017

This is now resolved.

NOTE: The test dependencies are going to stay in the pom because they don't cause any problems and the meta information is useful to users. I confirmed this is alright with @wilkinsona offline.

@rwinch rwinch closed this as completed Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants