We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DelegatingRequestMatcherHeaderWriter would be handier in combination with a composite HeaderWriter implementation:
DelegatingRequestMatcherHeaderWriter
HeaderWriter
new DelegatingRequestMatcherHeaderWriter(requestMatcher, new CompositeHeaderWriter(headerWriterList));
It would also simplify code in certain areas like HeaderWriterFilter:
HeaderWriterFilter
public HeaderWriterFilter(List<HeaderWriter> headerWriters) { // ... this.headerWriters = headerWriters; } public void doFilterInternal(...) { // ... for (HeaderWriter headerWriter : this.headerWriters) { headerWriter.writeHeaders(request, response); } }
would simplify to:
public HeaderWriterFilter(List<HeaderWriter> headerWriters) { // ... this.headerWriter = new CompositeHeaderWriter(headerWriters); } public void doFilterInternal(...) { // ... this.headerWriter.writeHeaders(request, response); }
The text was updated successfully, but these errors were encountered:
@jzheaux I would like to take this one.
Sorry, something went wrong.
Here is a pull request: #6455
718641a
Polish Javadoc and Whitespacing
bb1b9d9
Issue: gh-6453
Polish CompositeHeaderWriterTests
c82440e
Changed test to favor mocks in order to provide a stronger guarantee that the composite delegates to its components. Issue: gh-6453
jzheaux
Successfully merging a pull request may close this issue.
DelegatingRequestMatcherHeaderWriter
would be handier in combination with a compositeHeaderWriter
implementation:It would also simplify code in certain areas like
HeaderWriterFilter
:would simplify to:
The text was updated successfully, but these errors were encountered: