Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jwt.Builder should keep notBefore as an Instant #7442

Closed
jzheaux opened this issue Sep 16, 2019 · 0 comments
Closed

Jwt.Builder should keep notBefore as an Instant #7442

jzheaux opened this issue Sep 16, 2019 · 0 comments
Assignees
@jzheaux
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Milestone
5.2.0

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Sep 16, 2019

Like with issuedAt() and expiresAt(), notBefore() takes and Instant and it should stay that way.

Currently, the behavior is:

claims.put(NBF, nbf.getEpochSecond())

But it should be

claims.put(NBF, nbf);
@jzheaux jzheaux added type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Sep 16, 2019
@jzheaux jzheaux added this to the 5.2.0 milestone Sep 16, 2019
@jzheaux jzheaux self-assigned this Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
1 participant
@jzheaux