Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SAML 2.0 SP Metadata Endpoints #8693

Closed
jzheaux opened this issue Jun 15, 2020 · 2 comments
Closed

Support SAML 2.0 SP Metadata Endpoints #8693

jzheaux opened this issue Jun 15, 2020 · 2 comments
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone
General Backlog

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jun 15, 2020

No description provided.

@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Jun 15, 2020
@jzheaux jzheaux added this to the General Backlog milestone Jun 15, 2020
@jzheaux jzheaux mentioned this issue Jun 15, 2020
Closed
@jeanblanchard
Copy link

A side-note: Currently, the entityId for the Service Provider is set to {baseUrl}/saml2/service-provider-metadata/{registrationId}, which looks like a metadata URL, but is not bound to an actual endpoint, so that's a bit strange. At least I was surprised and initially thought something was wrong.

jkubrynski added a commit to jkubrynski/spring-security that referenced this issue Jul 4, 2020
@jkubrynski
Fix spring-projects#8693 Support SAML 2.0 SP Metadata Endpoints
dcfc676
jkubrynski added a commit to jkubrynski/spring-security that referenced this issue Jul 14, 2020
@jkubrynski
Fix spring-projects#8693 Support SAML 2.0 SP Metadata Endpoints
89e48df
@jzheaux jzheaux mentioned this issue Jul 31, 2020
Closed
jzheaux pushed a commit that referenced this issue Aug 5, 2020
@jkubrynski @jzheaux
SAML 2.0 SP Metadata Endpoint Support
8a35524 
Issue gh-8693
@jzheaux jzheaux closed this as completed in b999faa Aug 5, 2020
@scho
Copy link

scho commented Sep 8, 2020 •
edited

I've just tested RC-1 and was very happy to see this feature :)
One question though:
Is it intended, that the URI patterns like {baseUrl} or {registrationId} are not replaced with the actual values?

Edit:
I missed some parts of the implementation, please ignore my question!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Milestone
General Backlog
Development

No branches or pull requests
3 participants
@scho @jeanblanchard @jzheaux