Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML 2.0 filters should be in the web package #8819

Closed
jzheaux opened this issue Jul 8, 2020 · 0 comments
Closed

SAML 2.0 filters should be in the web package #8819

jzheaux opened this issue Jul 8, 2020 · 0 comments
Assignees
@jzheaux
Labels
in: saml2 An issue in SAML2 modules type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Milestone
6.0.0-RC1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jul 8, 2020

Saml2WebSsoAuthenticationFilter and Saml2WebSsoAuthenticationRequestFilter are in a package called .servlet.filter.

However, most other filters in Spring Security are in the .web package. Authentication filters specifically are in .web.authentication.

Saml2WebSsoAuthenticationFilter ought to be moved to .web.authentication
Saml2WebSsoAuthenticationRequestFilter ought to be moved to .web

Care should be taken to remain backward compatible which means deprecating the old classes. Also, the old classes would ideally delegate to the classes that are now in the correct location.
@jzheaux jzheaux added type: bug A general bug in: saml2 An issue in SAML2 modules labels Jul 8, 2020
@jzheaux jzheaux self-assigned this Jul 8, 2020
@jzheaux jzheaux mentioned this issue Jul 8, 2020
Closed
@jzheaux jzheaux added type: enhancement A general enhancement and removed type: bug A general bug labels May 15, 2021
@jzheaux jzheaux added this to the 6.x milestone Oct 14, 2021
@rwinch rwinch added the type: breaks-passivity A change that breaks passivity with the previous release label Jun 13, 2022
jzheaux added a commit that referenced this issue Sep 21, 2022
@jzheaux
Fix Import Order
44b7847 
Issue gh-8819
jzheaux added a commit that referenced this issue Sep 26, 2022
@jzheaux
Move Saml2 Authentication Filters
506e50b 
Issue gh-8819
@jzheaux jzheaux modified the milestones: 6.0.x, 6.0.0-RC1 Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
Spring Security Team
Status: Done
Milestone
6.0.0-RC1
Development

No branches or pull requests
2 participants
@rwinch @jzheaux