Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constant time comparisons for CSRF tokens #9291

Closed
rwinch opened this issue Dec 17, 2020 · 8 comments
Closed

Use constant time comparisons for CSRF tokens #9291

rwinch opened this issue Dec 17, 2020 · 8 comments
Assignees
Labels
in: web An issue in web modules (web, webmvc) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone

Comments

@rwinch
Copy link
Member

rwinch commented Dec 17, 2020

While it is not a practical exploit at this point, it is best to be defensive. We should change CSRF token comparison to use a constant time comparison to avoid side channel attacks.

NOTE: This was originally reported via Xhelal Likaj, xhelallikaj20@gmail.com

@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Dec 17, 2020
@rwinch rwinch closed this as completed in 40e027c Dec 17, 2020
@rwinch rwinch self-assigned this Dec 17, 2020
@rwinch rwinch added this to the 5.5.0-M2 milestone Dec 17, 2020
@ogarber
Copy link

ogarber commented Jan 4, 2021

Hi @rwinch , I have a question: will this fix also be merged in the older pipe-lines (I'm interesting in 5.2.x...).
Thank you in advance

@ogarber
Copy link

ogarber commented Jan 12, 2021

Hi @rwinch , sorry for annoying...
Did you see my previous comment?

@itsmevj
Copy link

itsmevj commented Jan 20, 2021

Hi @rwinch, will this fix will be merged in older versions like 5.2.x or when can we expect this release

@rwinch
Copy link
Member Author

rwinch commented Jan 20, 2021

I have backported the issue (see the linked issues). Each issue has a milestone with the expected release date.

@ogarber
Copy link

ogarber commented Jan 21, 2021

Thank you @rwinch !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants