Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermitAllSupport supports AuthorizeHttpRequestsConfigurer #10543

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

igorpele
Copy link
Contributor

PermitAllSupport supports either an ExpressionUrlAuthorizationConfigurer or an AuthorizeHttpRequestsConfigurer. If none or both are configured an error message is thrown.

Closes gh-10482

CLA was submitted.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2021
@marcusdacoregio marcusdacoregio removed the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2021
@marcusdacoregio marcusdacoregio added in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 23, 2021
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @igorpele, this is a good start! I've left my feedback inline.

@jzheaux jzheaux assigned jzheaux and unassigned marcusdacoregio Nov 29, 2021
@jzheaux jzheaux added this to the 6.0.0-M1 milestone Nov 29, 2021
PermitAllSupport supports either an ExpressionUrlAuthorizationConfigurer or an AuthorizeHttpRequestsConfigurer. If none or both are configured an error message is thrown.

Closes spring-projectsgh-10482
@jzheaux jzheaux merged commit 72109e2 into spring-projects:main Nov 30, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Nov 30, 2021

Thanks, @igorpele! This is now merged into main and backported to 5.7.0-M1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PermitAllSupport should support AuthorizeHttpRequestsConfigurer
4 participants