New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
messages.properties cleanup #11172
messages.properties cleanup #11172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Emkas!
I don't think there is value in adding the placeholders for untranslated properties, such as #ExceptionTranslationFilter.insufficientAuthentication=Full authentication is required to access this resource
.
I'm also hesitant to remove the message_nl.properties
file in case it causes unexpected behaviour in an application that is expecting it.
The remaining changes look good!
If you could update the PR with the above recommendations I will go ahead and merge it.
0d4b121
to
f24ee2e
Compare
@eleftherias, thank you for your feedback!
I mostly did as you asked, but there not much left, as I removed 3 biggest changes :-) Still in two changes I left some placeholders ( |
f24ee2e
to
3aaf84d
Compare
Thanks for the quick response @Emkas! I read through your justification for the 2 additional changes and I agree with you. |
3aaf84d
to
e61e2b4
Compare
I'm very pleased to hear that! 2 commits are back in place. As for now, everything is rebased. Finally only removed part is removing of empty |
Thanks @Emkas! This is now merged into main. |
Great :) |
I propose a few changes in messages*.properties which will make the files more 'unite' and consistent.
Here is the list: