New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on conmmons-codec by using java.util.Base64 #11319
Conversation
Thanks for the PR @j3graham To start, I think another change might be to remove commons-codec occurences from
I'll leave it to @jzheaux to review this further. |
Dependencies removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @j3graham! I've left some feedback inline.
...g/springframework/security/saml2/provider/service/web/Saml2AuthenticationTokenConverter.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/saml2/provider/service/web/Saml2AuthenticationTokenConverter.java
Show resolved
Hide resolved
Also, would you please consider rebasing this PR on |
Will be happy to rebase it when you're happy with this version. Interestingly the minor StandardCharsets change you called out requires Java 10, so will need to leave that out. |
New PR for 5.8.x: #11322 javax->jakarta changes were a bit awkward. Perhaps we can abandon this one in favour of the 5.8.x one and let the merge to main happen. |
@jzheaux Should I fix up this PR, or will the one from 5.8 get merged independently? |
Because of javax->jakarta, the merge isn't clean so it needs to be done manually. Since you've done that work already, I figure we can finish this PR, too. That said, if you are out of time, I can take care of it by cherry-picking the other and changing the package names. Up to you -- if you close the PR, I'll do the cherry-picking. If not, we can merge this one as well once it's ready. |
I cherry-picked the change and fixed the jakarta stuff. |
see gh-11318
First commit removes test usages of Base64 and some other minor commons-codec functions.