Add static factory method to AntPathRequestMather and RegexRequestMather #11965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusdacoregio
added
in: web
rwinch
requested changes
Oct 7, 2022
| * @param method the HTTP method to match. Must not be null. | ||
| * @since 5.8 | ||
| */ | ||
| public static RegexRequestMatcher forMethod(HttpMethod method) { |
There was a problem hiding this comment.
Right now there is a problem if someone needs to do a static import for both AntPathRequestMatcher.forMethod and RegexRequestMatcher.forMethod the usage would need to be fully qualified. I'd say we should use antMatcher and regexMatcher for the method names.
| Assert.notNull(method, "method cannot be null"); | ||
| return new AntPathRequestMatcher(MATCH_ALL, method.name()); | ||
| } | ||
|
|
There was a problem hiding this comment.
There doesn't seem to be a way to specify a pattern or a method and pattern via static factory method
| Assert.notNull(method, "method cannot be null"); | ||
| return new RegexRequestMatcher(".*", method.name()); | ||
| } | ||
|
|
There was a problem hiding this comment.
There doesn't seem to be a static factory method for both the method and pattern.
marcusdacoregio
force-pushed
the
gh-11938
branch
from
40720ba
to
69ac2e9
Compare
marcusdacoregio
force-pushed
the
gh-11938
branch
from
69ac2e9
to
f4fdd8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-11938