Document how to use the new requestMatchers and securityMatchers #12137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusdacoregio
added
in: docs
arsnova-bot
pushed a commit
to particify/arsnova-server
that referenced
this pull request
Nov 7, 2022
* Switched to jakarta.* namespace (from javax.*) for JEE. * Switched to JakartaEE variant of Pac4j's JEE dependency. * Adjusted alias forwarding logic for change in `AntPathMatcher`s `extractPathWithinPattern` implementation which can no longer return `null`. * Adjusted `ControllerExceptionHandler` to signature change of `ResponseEntityExceptionHandler`s `handleExceptionInternal` method. * Removed `ConstructorBinding` annotation for `ConfigurationProperties` contructors. * The new `securityMatchers` and `requestMatchers` methods are now used of `HttpSecurity` configuration. The `antMatcher` method was removed as of Spring Security 6.0. * Check for referential instead of structural equality when comparing `HttpMethod`. Breaking API change: * Trailing slashes are no longer accepted for URI's which are actually defined without one. Closes: #173 See: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0.0-M4-Release-Notes#spring-mvc-and-webflux-url-matching-changes See: spring-projects/spring-security#12137
jzheaux
requested changes
Nov 7, 2022
| ---- | ||
| ==== | ||
|
|
||
| Note that we are using some static factory methods to make the code more readable. |
There was a problem hiding this comment.
We usually avoid "we" in the docs. Something like "Note that the above sample uses static factory methods to improve readability."
You might also consider linking parts of "some static factory methods" to the JavaDoc for those factory methods.
| ---- | ||
| ==== | ||
|
|
||
| is equivalent too: |
There was a problem hiding this comment.
I think you mean "is equivalent to"
marcusdacoregio
force-pushed
the
gh-12100
branch
2 times, most recently
from
0b65154
to
8632b2f
Compare
jzheaux
approved these changes
Nov 7, 2022
marcusdacoregio
force-pushed
the
gh-12100
branch
from
8632b2f
to
e003e74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-12100