-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to use the new requestMatchers and securityMatchers #12137
Document how to use the new requestMatchers and securityMatchers #12137
Conversation
* Switched to jakarta.* namespace (from javax.*) for JEE. * Switched to JakartaEE variant of Pac4j's JEE dependency. * Adjusted alias forwarding logic for change in `AntPathMatcher`s `extractPathWithinPattern` implementation which can no longer return `null`. * Adjusted `ControllerExceptionHandler` to signature change of `ResponseEntityExceptionHandler`s `handleExceptionInternal` method. * Removed `ConstructorBinding` annotation for `ConfigurationProperties` contructors. * The new `securityMatchers` and `requestMatchers` methods are now used of `HttpSecurity` configuration. The `antMatcher` method was removed as of Spring Security 6.0. * Check for referential instead of structural equality when comparing `HttpMethod`. Breaking API change: * Trailing slashes are no longer accepted for URI's which are actually defined without one. Closes: #173 See: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0.0-M4-Release-Notes#spring-mvc-and-webflux-url-matching-changes See: spring-projects/spring-security#12137
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, @marcusdacoregio! I've left feedback inline.
---- | ||
==== | ||
|
||
Note that we are using some static factory methods to make the code more readable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually avoid "we" in the docs. Something like "Note that the above sample uses static factory methods to improve readability."
You might also consider linking parts of "some static factory methods" to the JavaDoc for those factory methods.
---- | ||
==== | ||
|
||
is equivalent too: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mean "is equivalent to"
0b65154
to
8632b2f
Compare
8632b2f
to
e003e74
Compare
Closes gh-12100