Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using modern Java features #12569

Merged
merged 2 commits into from Jun 22, 2023
Merged

Conversation

krzyk
Copy link
Contributor

@krzyk krzyk commented Jan 20, 2023

Used few modern Java features to reduce boilerplate and hopefully increase readability.
switch expressions, few lambdas, patterns for instanceof, also replaced few cases of new Long with correct Long.valueOf (because constructor for Long is deprecated).

I didn't replace all switches, because in some cases moving to switch expressions or new switch statements didn't reduce the amount of code.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 20, 2023
@sjohnr sjohnr added the for: team-attention This ticket should be discussed as a team before proceeding label Jan 20, 2023
Copy link

@zucchivan zucchivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Good job. =)

@jzheaux jzheaux self-assigned this Apr 24, 2023
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged for: team-attention This ticket should be discussed as a team before proceeding labels Jun 5, 2023
@jzheaux jzheaux added this to the 6.2.0-M1 milestone Jun 5, 2023
@jzheaux jzheaux merged commit 208fb62 into spring-projects:main Jun 22, 2023
2 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Jun 22, 2023

Thanks, @krzyk! This is now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants