Use consistent list of micrometer tags in web observation handler #13179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dfrommi Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
dfrommi
force-pushed
the
consistent-tag-list
branch
from
068845d
to
0f11589
Compare
|
@dfrommi Thank you for signing the Contributor License Agreement! |
jzheaux
requested changes
May 15, 2023
web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java
Show resolved
Hide resolved
jzheaux
added
in: web
dfrommi
force-pushed
the
consistent-tag-list
branch
3 times, most recently
from
749c8ed
to
dce4e1c
Compare
|
@jzheaux Thanks for the test-example. As requested, I've added the same change to the reactive class as well. |
dfrommi
force-pushed
the
consistent-tag-list
branch
from
dce4e1c
to
fc0e68b
Compare
jzheaux
force-pushed
the
consistent-tag-list
branch
from
fc0e68b
to
ed9d41c
Compare
The tag `spring.security.reached.filter.name` is only set if a filter-name is available, otherwise the tag is omitted entirely. This leads to issues with metric-exporters that don't support dynamic tags, but rather expect tag-names of a metric to be always the same. The most prominent example is the Prometheus-exporter. Instead of omitting the tag if no filer-name is set, a none-value is applied instead, making the tag-list consistent in all cases Closes spring-projectsgh-13179
Use StringUtils#hasText PR spring-projectsgh-13179
jzheaux
force-pushed
the
consistent-tag-list
branch
from
ed9d41c
to
9583b06
Compare
jzheaux
approved these changes
May 17, 2023
jzheaux
pushed a commit
that referenced
this pull request
May 18, 2023
The tag `spring.security.reached.filter.name` is only set if a filter-name is available, otherwise the tag is omitted entirely. This leads to issues with metric-exporters that don't support dynamic tags, but rather expect tag-names of a metric to be always the same. The most prominent example is the Prometheus-exporter. Instead of omitting the tag if no filer-name is set, a none-value is applied instead, making the tag-list consistent in all cases Closes gh-13179
|
Thanks, @dfrommi, for the PR! This is merged into |
jzheaux
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag
spring.security.reached.filter.nameis only set if a filter-name is available, otherwise the tag is omitted entirely. This leads to issues with metric-exporters that don't support dynamic tags, but rather expect tag-names of a metric to be always the same. The most prominent example is the Prometheus-exporter.Instead of omitting the tag if no filer-name is set, a none-value is applied instead, making the tag-list consistent in all cases