Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error On Unsupported Client Authentication Methods #13240

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Error On Unsupported Client Authentication Methods #13240

merged 1 commit into from
Jun 12, 2023

Conversation

jzheaux
Copy link
Contributor

@jzheaux jzheaux commented May 26, 2023

Related to #13144

@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement labels May 30, 2023
@jgrandja jgrandja requested a review from sjohnr May 30, 2023 16:11
sjohnr
sjohnr requested changes May 30, 2023
View reviewed changes
Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start, @jzheaux! I've added my thoughts below.

...ngframework/security/oauth2/client/endpoint/DefaultAuthorizationCodeTokenResponseClient.java Outdated Show resolved Hide resolved
@jzheaux jzheaux changed the base branch from main to 6.0.x June 6, 2023 02:59
@jzheaux jzheaux marked this pull request as ready for review June 6, 2023 04:22
sjohnr
sjohnr requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @jzheaux, this is looking really good! I've added just a few more comments below.

...ecurity/oauth2/client/endpoint/AbstractWebClientReactiveOAuth2AccessTokenResponseClient.java Outdated Show resolved Hide resolved
...ecurity/oauth2/client/endpoint/AbstractWebClientReactiveOAuth2AccessTokenResponseClient.java Show resolved Hide resolved
...ngframework/security/oauth2/client/endpoint/DefaultClientCredentialsTokenResponseClient.java Outdated Show resolved Hide resolved
...org/springframework/security/oauth2/client/endpoint/DefaultJwtBearerTokenResponseClient.java Outdated Show resolved Hide resolved
sjohnr
sjohnr approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jzheaux, I added one new item below. I'm good once this is addressed. 👍

...ngframework/security/oauth2/client/endpoint/DefaultClientCredentialsTokenResponseClient.java Outdated Show resolved Hide resolved
@jzheaux jzheaux added this to the 6.0.4 milestone Jun 12, 2023
@jzheaux jzheaux merged commit 5f26dae into spring-projects:6.0.x Jun 12, 2023
2 checks passed
@jzheaux jzheaux deleted the gh-13144 branch June 12, 2023 21:14
@benfonty benfonty mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjohnr sjohnr sjohnr approved these changes

Assignees

@sjohnr sjohnr

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
Spring Security Team
Archived in project
Milestone
6.0.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jzheaux @sjohnr @jgrandja