Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify configuration of OAuth2 Client component model #13587

Merged

Conversation

sjohnr
Copy link
Member

@sjohnr sjohnr commented Jul 26, 2023

This PR is the most recent iteration of design work for simplifying the configuration of the OAuth2 Client component model. The following list documents progress:

  • Java config
  • Java config tests
  • XML config
  • XML config tests
  • Reactive
  • Reactive tests
  • Reference documentation (including use-case specific examples)

Issue gh-11783

@sjohnr sjohnr added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jul 26, 2023
@sjohnr sjohnr added this to the 6.2.0-M2 milestone Jul 26, 2023
@sjohnr sjohnr self-assigned this Jul 26, 2023
@sjohnr sjohnr requested a review from jgrandja July 26, 2023 22:11
@sjohnr sjohnr force-pushed the gh-11783-oauth2-client-configuration branch from 4bc7a14 to 995b1eb Compare July 26, 2023 22:16
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sjohnr ! This looks great! Please see review comments for a couple of very minor changes.

@sjohnr sjohnr force-pushed the gh-11783-oauth2-client-configuration branch from 995b1eb to dbf9b50 Compare August 9, 2023 18:58
@rishiraj88
Copy link

Still in progress?

@sjohnr sjohnr merged commit 5828e4e into spring-projects:main Aug 9, 2023
2 checks passed
@sjohnr sjohnr deleted the gh-11783-oauth2-client-configuration branch August 9, 2023 19:14
@sjohnr
Copy link
Member Author

sjohnr commented Aug 9, 2023

@rishiraj88 this is now merged. I'll be working on reference documentation next to demonstrate how the feature works. Are you interested in trying it out on a SNAPSHOT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants