Replace deprecated method #13649
Merged
Replace deprecated method #13649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace HttpMethod.resolve() to HttpMethod.valueOf()
spring-projects-issues
added
the
status: waiting-for-triage
jesperronn
reviewed
Aug 15, 2023
| @@ -66,7 +66,7 @@ public DispatcherTypeRequestMatcher(DispatcherType dispatcherType, @Nullable Htt | |||
| @Override | |||
| public boolean matches(HttpServletRequest request) { | |||
| if (this.httpMethod != null && StringUtils.hasText(request.getMethod()) | |||
| && this.httpMethod != HttpMethod.resolve(request.getMethod())) { | |||
| && this.httpMethod != HttpMethod.valueOf(request.getMethod())) { | |||
There was a problem hiding this comment.
as I read the deprecated method:
it seems to have a null-check.
I wonder if you also need a null check here (request.getMethod() == null)?
There was a problem hiding this comment.
It's not needed since that condition is checked on line 68 with StringUtils.hasText(request.getMethod())
|
looks good to me, but if request.getMethod() can be null it needs a null check? If request.getMethod() == null and no null check is introduced, then it will change behaviour slightly I dont know if that is a significant change or it will ever make a difference. |
jzheaux
added
in: web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I replaced
HttpMethod.resolve()toHttpMethod.valueOf()HttpMethod.resolve()is deprecated since Spring Framework 6.0.Thank you.