Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix corrupted saml2 metadata once special characters are present #13777

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix corrupted saml2 metadata once special characters are present #13777

merged 1 commit into from
Sep 25, 2023

Conversation

JannickWeisshaupt
Copy link

Fixes corrupted Saml2Metadata once special characters are present. The cause of this bug is that the length in bytes, which is correct for the content length is not equal to the java string length.

See Issue #13776

@pivotal-cla
Copy link

@JannickWeisshaupt Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@JannickWeisshaupt Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 6, 2023
@marcusdacoregio marcusdacoregio self-assigned this Sep 11, 2023
@marcusdacoregio marcusdacoregio added type: bug A general bug in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 11, 2023
@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Sep 11, 2023 •
edited

Hi @JannickWeisshaupt, can you add a test that verifies the correct behavior? In addition to that, can you please target the 5.8.x branch? If you do not have time to do that let me know so I will go ahead and do that on my side.

@JannickWeisshaupt JannickWeisshaupt changed the base branch from main to 5.8.x September 18, 2023 10:14
@JannickWeisshaupt
Copy link
Author

Hi @marcusdacoregio, should be done!

@marcusdacoregio
Copy link
Contributor

Nice @JannickWeisshaupt. In preparation for merging, can you please squash your commits into one? Ideally, the single commit should have the following message:

Fix corrupted saml2 metadata when special characters are present

Closes gh-13776

@marcusdacoregio marcusdacoregio added this to the 5.8.8 milestone Sep 18, 2023
@JannickWeisshaupt
Copy link
Author

Commits are squashed @marcusdacoregio

@marcusdacoregio marcusdacoregio merged commit b67218c into spring-projects:5.8.x Sep 25, 2023
1 of 2 checks passed
@marcusdacoregio
Copy link
Contributor

Thanks, @JannickWeisshaupt. This is now merged into 5.8.x, 6.0.x, 6.1.x and main

@JannickWeisshaupt JannickWeisshaupt deleted the fix-saml2-metadata-corruption branch October 4, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusdacoregio marcusdacoregio marcusdacoregio approved these changes

Assignees

@marcusdacoregio marcusdacoregio

Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Projects
Spring Security Team
Status: No status
Milestone
5.8.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JannickWeisshaupt @pivotal-cla @marcusdacoregio @spring-projects-issues