Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve The matchingRequestParameterName From The Query String #13817

Merged
merged 1 commit into from Sep 14, 2023
Merged

Resolve The matchingRequestParameterName From The Query String #13817

merged 1 commit into from Sep 14, 2023

Commits on Sep 14, 2023

  1. Resolve The matchingRequestParameterName From The Query String 

    Prior to this commit, the ServletRequest#getParameter method was used in order to verify if the matchingRequestParameterName was present in the request. That method has some side effects like interfering in the execution of the ServletRequest#getInputStream and ServletRequest#getReader method when the request is an HTTP POST (if those methods are invoked after getParameter, or vice-versa, the content won't be available). This commit makes that we only use the query string to check for the parameter, avoiding draining the request's input stream.

Closes spring-projectsgh-13731
    @marcusdacoregio
    marcusdacoregio committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6cf03ef View commit details
    Browse the repository at this point in the history