Add servletPath support to AuthorizeHttpRequests #13857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @jzheaux . |
sjohnr
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Thanks for the work so far @jzheaux! As mentioned below, I particularly like the separation between creating RequestMatcherBuilder through a factory and use of that interface for creating RequestMatcher instances. I'm not sure if we could improve on the contract needing an ApplicationContext at this point, but will ponder it some more.
...rg/springframework/security/config/web/util/matcher/ServletRequestMatcherBuilderFactory.java
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authorization/authorize-http-requests.adoc
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/config/web/util/matcher/RequestMatcherBuilders.java
Outdated
Show resolved
Hide resolved
...rg/springframework/security/config/web/util/matcher/ServletRequestMatcherBuilderFactory.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/config/web/util/matcher/RequestMatcherBuilders.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/config/web/util/matcher/RequestMatcherBuilders.java
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authorization/authorize-http-requests.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authorization/authorize-http-requests.adoc
Outdated
Show resolved
Hide resolved
.../java/org/springframework/security/config/annotation/web/AbstractRequestMatcherRegistry.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/config/web/util/matcher/RequestMatcherBuilders.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/security/config/web/util/matcher/ServletRegistrationCollection.java
Outdated
Show resolved
Hide resolved
jzheaux
force-pushed
the
gh-13562
branch
3 times, most recently
from
45f2a18
to
678fd07
Compare
jzheaux
changed the title
jzheaux
added
in: config
jzheaux
force-pushed
the
gh-13562
branch
2 times, most recently
from
9cf81e7
to
795c382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the logic
AuthorizeHttpRequestsConfigureruses to generateRequestMatcherinstances, simplifying howAntPathRequestMatcherandMvcRequestMatcherinstances are generated.It exposes this through the
forServletPatternDSL method.Closes gh-13562