Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of GET SAML logout requests #13970

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix parsing of GET SAML logout requests #13970

merged 1 commit into from
Oct 16, 2023

Conversation

Dyndyn
Copy link

@Dyndyn Dyndyn commented Oct 6, 2023

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 6, 2023
@marcusdacoregio marcusdacoregio self-assigned this Oct 11, 2023
@marcusdacoregio marcusdacoregio added type: bug A general bug in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 11, 2023
@marcusdacoregio
Copy link
Contributor

Hi, @Dyndyn. Thank you for the fix. Can you please target the 6.1.x branch?

@marcusdacoregio
Copy link
Contributor

Also, please run ./gradlew format check to check if the build passes

@Dyndyn Dyndyn changed the base branch from main to 6.1.x October 12, 2023 07:27
@Dyndyn Dyndyn force-pushed the fix/saml2-logout-get-request branch from 606c45b to 544c176 Compare October 12, 2023 07:47
@Dyndyn
Copy link
Author

Dyndyn commented Oct 12, 2023

Hi, @marcusdacoregio. I fixed format in the test and changed target

@marcusdacoregio marcusdacoregio added this to the 6.1.5 milestone Oct 16, 2023
@marcusdacoregio marcusdacoregio merged commit a884a45 into spring-projects:6.1.x Oct 16, 2023
2 checks passed
@marcusdacoregio
Copy link
Contributor

Thanks, @Dyndyn. This is now merged into 6.1.x and main.

@marcusdacoregio marcusdacoregio mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Projects
Spring Security Team
Status: No status
Milestone
6.1.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dyndyn @marcusdacoregio @spring-projects-issues