-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RoleHierarchyBuilder #14196
Add RoleHierarchyBuilder #14196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @FdHerrera! Given that this is ultimately in the service of RoleHierarchyImpl
, will you please move this into that class? In that way, I believe it will also better align with #13788
...rc/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyBuilder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyBuilder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyBuilder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyBuilder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyBuilder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyBuilder.java
Outdated
Show resolved
Hide resolved
Thank you very much for your feedback, @jzheaux ! I'll start implementing your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @FdHerrera! Things are shaping up nicely. I've left a little bit more feedback inline.
Also, in preparation for merging, will you please squash your commits into a single commit that looks something like this:
Add RoleHierarchy.Builder
Closes gh-13300
core/src/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/springframework/security/access/hierarchicalroles/RoleHierarchyImpl.java
Outdated
Show resolved
Hide resolved
Thank you for the thorough review and constructive feedback! I appreciate the collaborative back-and-forth @jzheaux . I implemented your suggestions and squashed the commits, I think is looking pretty good let me hear your thoughts! |
Thanks, @FdHerrera! I've added a polish to make it align more closely with the rest of the codebase stylistically. For now, I think we should leave out |
Looks good @jzheaux thank you for your help! |
Create builder class to declaratively create a RoleHierarchy with a fluent API, add test. Closes #13300
gh-13300