Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo: Update authorize-http-requests.adoc #14563

Merged
merged 1 commit into from Feb 7, 2024
Merged

Typo: Update authorize-http-requests.adoc #14563

merged 1 commit into from Feb 7, 2024

Conversation

boulce
Copy link
Contributor

@boulce boulce commented Feb 7, 2024 •
edited

'patters' -> 'pattern'

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 7, 2024
@marcusdacoregio marcusdacoregio self-assigned this Feb 7, 2024
@marcusdacoregio
Copy link
Contributor

Hi, @boulce.

Can you please merge all your commits into one? All commits should be squashed too. There is no need to open one PR for each typo fix.

#14562
#14561
#14560
#14559

I'll go ahead and close the PRs linked above and keep this one open.

@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 7, 2024
@boulce
Typo: Update authorize-http-requests.adoc
a67affb 
'patters' -> 'pattern'
-----
'db' -> "db",
'ADMIN' -> "ADMIN"
They should be string type
-----
There is no semicolon. I added it.
-----
There is no semicolon at the end of the sentence. So I added
@boulce
Copy link
Contributor Author

boulce commented Feb 7, 2024

Hi, @boulce.

Can you please merge all your commits into one? All commits should be squashed too. There is no need to open one PR for each typo fix.

#14562 #14561 #14560 #14559

I'll go ahead and close the PRs linked above and keep this one open.

I did it! Thanks for your feedback.

@marcusdacoregio marcusdacoregio added this to the 6.2.2 milestone Feb 7, 2024
@marcusdacoregio marcusdacoregio merged commit fd1db06 into spring-projects:6.2.x Feb 7, 2024
3 checks passed
@marcusdacoregio
Copy link
Contributor

Thanks, @boulce. This is now merged into 6.2.x and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Milestone
6.2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boulce @marcusdacoregio @spring-projects-issues