Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DelegatingAuthenticationConverter #14655

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Add DelegatingAuthenticationConverter #14655

merged 1 commit into from
Mar 13, 2024

Conversation

CrazyParanoid
Copy link

Closes gh-14644

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 27, 2024
@CrazyParanoid
Copy link
Author

@jzheaux Can you review this please? I will be very grateful.

@CrazyParanoid CrazyParanoid changed the title Added DelegatingBearerTokenResolver Added DelegatingAuthenticationConverter Mar 5, 2024
jzheaux
jzheaux requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CrazyParanoid! I've left my feedback inline.

.../java/org/springframework/security/web/authentication/DelegatingAuthenticationConverter.java Outdated Show resolved Hide resolved
.../java/org/springframework/security/web/authentication/DelegatingAuthenticationConverter.java Outdated Show resolved Hide resolved
.../java/org/springframework/security/web/authentication/DelegatingAuthenticationConverter.java Outdated Show resolved Hide resolved
@jzheaux jzheaux self-assigned this Mar 6, 2024
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 6, 2024
@CrazyParanoid
Copy link
Author

Thanks @jzheaux for feedback! All your comments have been resolved.

@jzheaux jzheaux added this to the 6.3.0-M3 milestone Mar 13, 2024
@jzheaux jzheaux changed the title Added DelegatingAuthenticationConverter Add DelegatingAuthenticationConverter Mar 13, 2024
@jzheaux jzheaux merged commit c0928bf into spring-projects:main Mar 13, 2024
3 checks passed
@CrazyParanoid CrazyParanoid mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
Spring Security Team
Status: Done
Milestone
6.3.0-M3
Development

Successfully merging this pull request may close these issues.

Support delegating BearerTokenResolver
3 participants
@CrazyParanoid @jzheaux @spring-projects-issues