Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InitializeUserDetailsBeanManagerConfigurer inject PasswordEncoder into DaoAuthenticationProvider constructor #14766

Merged
merged 1 commit into from Apr 8, 2024
Merged

InitializeUserDetailsBeanManagerConfigurer inject PasswordEncoder into DaoAuthenticationProvider constructor #14766

merged 1 commit into from Apr 8, 2024

Conversation

kse-music
Copy link
Contributor

Closes gh-14691

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 17, 2024
@sjohnr sjohnr self-assigned this Apr 4, 2024
@sjohnr
Copy link
Member

sjohnr commented Apr 4, 2024

Thanks for contributing @kse-music! Could you do me a favor and rebase on the latest main? It looks as though this class was recently modified as part of enhanced password support in 6.3 and your changes are now in conflict.

@sjohnr sjohnr added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 4, 2024
@kse-music
Copy link
Contributor Author

@sjohnr has rebase to the latest main branch

@sjohnr sjohnr merged commit 75197ca into spring-projects:main Apr 8, 2024
3 checks passed
@sjohnr
Copy link
Member

sjohnr commented Apr 8, 2024

Thanks @kse-music!

@sjohnr sjohnr added this to the 6.3.0-RC1 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjohnr sjohnr

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
Spring Security Team
Status: Done
Milestone
6.3.0-RC1
Development

Successfully merging this pull request may close these issues.

InitializeUserDetailsBeanManagerConfigurer should use Constructor Injection
3 participants
@kse-music @sjohnr @spring-projects-issues