Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jackson Support for Objects stored in HttpSession #3812

Closed
wants to merge 64 commits into from

Conversation

jeetmp3
Copy link
Contributor

@jeetmp3 jeetmp3 commented Apr 14, 2016

Hi @rwinch sorry it's got delayed. I've created mix-ins to add Jackson support(#3736).
Please review the code and let me know feedback. I've modified some existing classes

  1. DefaultSavedRequest added builder class with private constructor
  2. WebAuthenticationDetails added one private constructor to exclude HttpServletRequest dependency in Jackson deserialization.
  3. CasAuthenticationToken, RememberMeAuthenticationToken, AnonymousAuthenticationToken added new private constructor to ensure keyHash correctly deserialized and added static methods in AbstractAuthenticationToken which helps in constructing these *AuthenticationToken implementations

PS: I havn't update Apache Licence yet. Need your help in updating the same

  • I have signed the CLA

…ed in CasAuthenticationToken jackson deserialization
@jeetmp3
Copy link
Contributor Author

jeetmp3 commented Aug 9, 2016

Thanks for the feedback!
I've finish all the changes mentioned in comments and also updated Spring Session Redis Sample.

@rwinch rwinch modified the milestone: 4.2.0 M1 Aug 15, 2016
@rwinch rwinch added in: web An issue in web modules (web, webmvc) in: cas An issue in spring-security-cas type: enhancement A general enhancement status: duplicate A duplicate of another issue labels Sep 2, 2016
@rwinch rwinch closed this in d77ca17 Sep 2, 2016
@rwinch
Copy link
Member

rwinch commented Sep 2, 2016

Thanks for the PR!

This is now merged into master via d77ca17

You will notice a series of commits 8ad0003 that perform some polish on the Pull Request you submitted. If you are able, please review my changes.

@driverpt
Copy link

driverpt commented Oct 4, 2016

@rwinch , can this be backported to Spring Security?

@rwinch
Copy link
Member

rwinch commented Oct 4, 2016

@driverpt Spring Security 4.2 will be out very soon, so I don't think we will be back porting it. What version do you want it to be back ported to?

@driverpt
Copy link

driverpt commented Oct 4, 2016

@rwinch , thanks for the quick reply. I'm currently using the one used in Spring Boot (4.1.1). Is 4.2.0 M1 a good drop-in replacement for 4.1.1 in Spring Boot ?

@rwinch
Copy link
Member

rwinch commented Oct 4, 2016

@driverpt Yes it is. You can also just copy paste the necessary classes into your project until Spring Security goes GA. Keep in mind we are making a change to how things are done in order to support newer versions of Jackson. See #4073

@driverpt
Copy link

driverpt commented Oct 4, 2016

Problem is, Spring Boot uses Jackson 2.8.1

@rwinch
Copy link
Member

rwinch commented Oct 4, 2016

@driverpt Right. See the PR #4078 that works around the related Jackson regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: cas An issue in spring-security-cas in: core An issue in spring-security-core in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants