Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Jackson Support for Objects stored in HttpSession #3812
PS: I havn't update Apache Licence yet. Need your help in updating the same
Thanks for the PR!
The more I think about this the more I am uncomfortable merging this so close to GA. There are a large amount of changes in this PR and I do not think I will be able to give this a proper review by Wednesday (the release). For this reason, I'm bumping this to 4.2
To be clear...I'm sad that this is getting bumped as I know it will be of great value to users. However, I know that it is more important we get a quality release out of this than trying to force this feature in.
One thing we will want to ensure is that we add documentation to the reference to use this. We can wait for the documentation until this feature is reviewed, but we will need this before this is "production ready".
It is your project, but I just threw in my 50 cents here. 24 "real" files changes still sounds like a lot. I understand that Jackson is "defacto JSON" in Java, but it would be nice if I had this great "fast Johnson JSON serrializer" going on (I have not) that I could benifit from this PR and not having to add 24 more classes. Hiding it behind GenericJackson2JsonRedisSerializer wouldn't help, either -- because it's not abstract enough. It says so in its name.
But you get the point, I will quiet down now.