Fix when WhiteListedAllowFromStrategy returns "DENY" #4559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, if the return from getAllowFromValue(request) is "DENY", then the X-Frame-Options header's value will proceed to be written as "ALLOW FROM DENY" - an invalid value. This commit adds a condition in the if clause that checks whether allowFromValue is "DENY". This way, the X-Frame-Options header will be written as "ALLOW FROM origin" or "DENY".
|
@nathanCFRA Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@nathanCFRA Thank you for signing the Contributor License Agreement! |
rwinch
added
type: bug
rwinch
added a commit
that referenced
this pull request
Oct 30, 2017
|
Thanks for the PR @nathanCFRA! I merged this in via 02a78b1 and polished it via 93ac706 |
rwinch
changed the title
thomasdarimont
pushed a commit
to thomasdarimont/spring-security
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, if the return from
getAllowFromValue(request)isDENY,then the X-Frame-Options header's value will proceed to be written as
ALLOW FROM DENY- an invalid value.This commit adds a condition in the if clause that checks whether
allowFromValue is
DENY. This way, the X-Frame-Options header will bewritten as
ALLOW FROM [origin]orDENY.If
XFrameOptionsHeaderWriteris used with the strategyWhiteListedAllowFromStrategy, then any supplied origin that is not a direct match on the provided white list should result inDENYbeing written. But stepping through the code will show that if there is no match,getAllowFromValue()will returnDENY, then will proceed to be concatenated withALLOW FROM, resulting inALLOW FROM DENY.If the supplied origin has a match on the white list, then result is as expected.