Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionRegistryImpl uses computeIfAbsent #6221

Merged
merged 1 commit into from Dec 5, 2018
Merged

SessionRegistryImpl uses computeIfAbsent #6221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 1 addition & 11 deletions core/src/main/java/org/springframework/security/core/session/SessionRegistryImpl.java
View file
Open in desktop
Expand Up @@ -132,17 +132,7 @@ public void registerNewSession(String sessionId, Object principal) {
sessionIds.put(sessionId,
new SessionInformation(principal, sessionId, new Date()));

Set<String> sessionsUsedByPrincipal = principals.get(principal);

if (sessionsUsedByPrincipal == null) {
sessionsUsedByPrincipal = new CopyOnWriteArraySet<>();
Set<String> prevSessionsUsedByPrincipal = principals.putIfAbsent(principal,
sessionsUsedByPrincipal);
if (prevSessionsUsedByPrincipal != null) {
sessionsUsedByPrincipal = prevSessionsUsedByPrincipal;
}
}

Set<String> sessionsUsedByPrincipal = principals.computeIfAbsent(principal, key -> new CopyOnWriteArraySet<>());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Local variable is needed here for logger when trace is enabled

sessionsUsedByPrincipal.add(sessionId);

if (logger.isTraceEnabled()) {
Expand Down