Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates OAuth2ResourceServer configuration tests #6904

Merged
merged 1 commit into from Jun 7, 2019
Merged

Updates OAuth2ResourceServer configuration tests #6904

merged 1 commit into from Jun 7, 2019

Conversation

vishalvrv9
Copy link
Contributor

As per #6516, OAuth2ResourceConfiguration#extractAuthorities was deprecated

This PR updates OAuth2ResourceServerConfigurerTests and OAuth2ResourceServerSpecTests to use setJwtGrantedAuthoritiesConverter instead of extractAuthorities

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 25, 2019
@vishalvrv9 vishalvrv9 mentioned this pull request May 25, 2019
Closed
@jzheaux
Copy link
Contributor

jzheaux commented May 28, 2019

@vishalvrv9 thanks so much for the PR! Will you please double-check your import settings in your IDE? It'd be nice to keep the imports expanded as they are -- it appears that your IDE may be collapsing them down to * in some cases.

@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels May 29, 2019
@jzheaux jzheaux self-assigned this May 29, 2019
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement labels May 29, 2019
@jzheaux jzheaux merged commit b6e8997 into spring-projects:master Jun 7, 2019
@jzheaux jzheaux added this to the 5.2.0.M3 milestone Jun 7, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Jun 7, 2019

Thanks, @vishalvrv9! This is now merged into master.

@jzheaux jzheaux removed the status: waiting-for-feedback We need additional information before we can continue label Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vishalvrv9 @jzheaux @spring-projects-issues