Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OAuth2User extends OAuth2AuthenticatedPrincipal #7383

Merged
merged 1 commit into from Sep 9, 2019
Merged

Make OAuth2User extends OAuth2AuthenticatedPrincipal #7383

merged 1 commit into from Sep 9, 2019

Conversation

eddumelendez
Copy link
Contributor

Fixes gh-7378

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 6, 2019
jzheaux
jzheaux requested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @eddumelendez! I've left just one piece of feedback inline.

oauth2/oauth2-core/src/main/java/org/springframework/security/oauth2/core/user/OAuth2User.java Outdated Show resolved Hide resolved
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 6, 2019
@jzheaux jzheaux added this to the 5.2.0 milestone Sep 6, 2019
@jzheaux jzheaux self-assigned this Sep 6, 2019
@eddumelendez
Copy link
Contributor Author

Thanks @jgrandja ! I have updated the PR

@jzheaux jzheaux merged commit 91bf1c7 into spring-projects:master Sep 9, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Sep 9, 2019

Thanks, @eddumelendez, this is now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandja jgrandja jgrandja left review comments

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

OAuth2User should extend OAuth2AuthenticatedPrincipal
4 participants
@eddumelendez @jzheaux @jgrandja @spring-projects-issues