Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit test maintainability #7694

Merged
merged 1 commit into from Dec 12, 2019
Merged

Improve unit test maintainability #7694

merged 1 commit into from Dec 12, 2019

Conversation

rafahop
Copy link
Contributor

@rafahop rafahop commented Dec 2, 2019

Replace test vectors with a list of test objects to improve readability/maintainability

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 2, 2019
@rafahop rafahop mentioned this pull request Dec 2, 2019
Merged
@eleftherias eleftherias self-assigned this Dec 12, 2019
@eleftherias eleftherias added in: crypto An issue in spring-security-crypto type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 12, 2019
@eleftherias eleftherias merged commit c71e84b into spring-projects:master Dec 12, 2019
@eleftherias
Copy link
Contributor

Thanks for the PR @rafahop! This is now merged into master.

@eleftherias eleftherias added this to the 5.3.0.M1 milestone Dec 12, 2019
@eleftherias eleftherias added type: task A general task and removed type: enhancement A general enhancement labels Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eleftherias eleftherias

Labels
in: crypto An issue in spring-security-crypto type: task A general task
Projects
None yet
Milestone
5.3.0.M1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rafahop @eleftherias @spring-projects-issues