-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify retrieving Introspection-specific attributes #8740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @qavid! I've left some feedback inline.
...h2-jose/src/main/java/org/springframework/security/oauth2/jwt/JwtAuthenticatedPrincipal.java
Outdated
Show resolved
Hide resolved
...h2-jose/src/main/java/org/springframework/security/oauth2/jwt/JwtAuthenticatedPrincipal.java
Outdated
Show resolved
Hide resolved
...security/oauth2/server/resource/introspection/OAuth2IntrospectionAuthenticatedPrincipal.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @qavid! I've left one more comment inline.
...security/oauth2/server/resource/introspection/OAuth2IntrospectionAuthenticatedPrincipal.java
Outdated
Show resolved
Hide resolved
Thanks again, @qavid. In preparation for merging, will you please squash your commits and format the commit message? |
In order to simplify retrieving of OAuth 2.0 Introspection specific attributes, OAuth2IntrospectionClaimAccessor interface was introduced and also new OAuth2AuthenticatedPrincipal implementing this new interface (OAuth2IntrospectionAuthenticatedPrincipal). Also DefaultOAuth2AuthenticatedPrincipal was replaced by OAuth2IntrospectionAuthenticatedPrincipal in cases where OAuth 2.0 Introspection is performed (NimbusOpaqueTokenIntrospector, NimbusReactiveOpaqueTokenIntrospector). DefaultOAuth2AuthenticatedPrincipal can be still used by applications that introspected the token without OAuth 2.0 Introspection. OAuth2IntrospectionAuthenticatedPrincipal will also be used as a default principal in tests where request is post-processed/mutated by OpaqueTokenRequestPostProcessor/OpaqueTokenMutator. Closes gh-6489
I have squashed commits and updated commit message. Btw, link is pointing to non-existing document. Same incorrect link is on this wiki page |
Thanks, @qavid, I've updated my message as well as my reply template. |
Fixes gh-6489