Support custom filter in Server Kotlin DSL #8850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Jul 21, 2020
There was a problem hiding this comment.
Thanks for the PR @evgeniycheban!
I have left some feedback inline.
| @@ -89,6 +90,33 @@ class ServerHttpSecurityDsl(private val http: ServerHttpSecurity, private val in | |||
| this.http.securityMatcher(securityMatcher) | |||
| } | |||
|
|
|||
| /** | |||
| * Adds a [WebFilter] at a specific position. | |||
There was a problem hiding this comment.
It would be nice to have an example of how to use this method, similar to what we have in HttpSecurityDsl.
The same applies for addFilterBefore and addFilterAfter.
| @@ -123,4 +129,74 @@ class ServerHttpSecurityDslTests { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun `add filter at is applied`() { | |||
There was a problem hiding this comment.
Please make the test names more descriptive.
For example, this test could be renamed to:
add filter at applies custom at specified filter position
eleftherias
added
in: config
|
Thanks for the PR @evgeniycheban! This is now merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-8783