Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Testcontainer should be stopped after LettuceConnectionFactory #1086

Closed
vpavic opened this issue Jun 1, 2018 · 1 comment
Closed
Assignees
Labels
in: build An issue in the build type: enhancement A general enhancement
Milestone

Comments

@vpavic
Copy link
Contributor

vpavic commented Jun 1, 2018

Our Redis based integration tests are currently stopping Redis Testcontainer before LettuceConnectionFactory which causes shutdown waits due to Lettuce trying to complete pending commands. More details about this can be found in redis/lettuce#667.

Since we have several integration tests that spin up Redis Testcontainer, this adds up quite a lot of time to our build.

We should move management of Redis Testcontainer to application context by registering it as @Bean, similarly like we do in Gretty based integration tests, and having LettuceConnectionFactory depend on test container bean to ensure a clean shutdown.

@vpavic vpavic added type: enhancement A general enhancement in: build An issue in the build labels Jun 1, 2018
@vpavic vpavic added this to the 2.0.4 milestone Jun 1, 2018
@vpavic vpavic self-assigned this Jun 1, 2018
@vpavic vpavic closed this as completed in 63f1050 Jun 1, 2018
@vpavic
Copy link
Contributor Author

vpavic commented Jun 1, 2018

This reduced build time from 17 minutes down to less than 8 minutes on my machine.

Update: Jenkins is down to 11 minutes (previously 19) while Travis CI is down to 17 minutes (previously 26).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant