Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spring Boot based Hazelcast samples #1902

Closed
vpavic opened this issue Aug 26, 2021 · 0 comments
Closed

Fix Spring Boot based Hazelcast samples #1902

vpavic opened this issue Aug 26, 2021 · 0 comments
Assignees
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone

Comments

@vpavic
Copy link
Contributor

vpavic commented Aug 26, 2021

There are several things wrong with the Spring Boot based Hazelcast samples:

  • configurations declare beans named clientConfig implying the use of Hazelcast in a client-server topology, while the actual type is com.hazelcast.config.Config which means the embedded server topology is used (coupled with this the original, Hazelcast 3.x based sample, declares the dependency on hazelcast-client)
  • tests configure Hazelcast containers which are not needed, because as explained above the sample actually uses the embedded server topology - additionally these containers use latest tag which makes the build non-reproducible
@vpavic vpavic added type: bug A general bug in: docs An issue in Documentation or samples labels Aug 26, 2021
@vpavic vpavic added this to the 2.6.0-RC1 milestone Aug 26, 2021
@vpavic vpavic self-assigned this Aug 26, 2021
@vpavic vpavic closed this as completed in 5b7aee7 Aug 26, 2021
@vpavic vpavic added for: backport-to-2.4.x Designates an issue for backport to 2.4.x for: backport-to-2.5.x Designates an issue for backport to 2.5.x labels Aug 26, 2021
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-2.5.x Designates an issue for backport to 2.5.x for: backport-to-2.4.x Designates an issue for backport to 2.4.x labels Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants