Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize MapSession use of UUID.randomUUID() #271

Closed
rwinch opened this issue Aug 19, 2015 · 0 comments
Closed

Minimize MapSession use of UUID.randomUUID() #271

rwinch opened this issue Aug 19, 2015 · 0 comments
Milestone
1.1.0 M1

Comments

@rwinch
Copy link
Member

rwinch commented Aug 19, 2015

There are places that new MapSession() is invoked which invokes UUID.randomUUID(). This means the secure random generator is used unnecessarily. We should provide an alternative constructor that accepts the id and avoids the UUID.randomUUID() invocation to improve performance.
@rwinch rwinch added this to the 1.1.0 M1 milestone Aug 19, 2015
@rwinch rwinch closed this as completed in 5fd2c71 Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0 M1
Development

No branches or pull requests
1 participant
@rwinch