Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove component scan #183

Closed
jvalkeal opened this issue Dec 21, 2017 · 0 comments
Closed

Remove component scan #183

jvalkeal opened this issue Dec 21, 2017 · 0 comments
Labels
type/bug Is a bug report

Comments

@jvalkeal
Copy link
Contributor

As scan is evil, remove @ComponentScan from SpringShellAutoConfiguration in favour of defining beans manually. This allows customisation of commands with conditionals(assuming user knows what to override).
@jvalkeal jvalkeal added the type/bug Is a bug report label Dec 21, 2017
ericbottard added a commit to ericbottard/spring-shell that referenced this issue Dec 24, 2017
@ericbottard
Make ResultHandlers configuration more explicit
3e8ed87 
Handle exit as a dedicated case (prevents eg 'exit' commands in scripts to make script quit)
Add an example of custom ApplicationRunner

Fixes spring-projects#187
Fixes spring-projects#183
@ericbottard ericbottard mentioned this issue Dec 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Is a bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jvalkeal