Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalUI should allow setting area #872

Closed
jvalkeal opened this issue Sep 22, 2023 · 0 comments
Closed

TerminalUI should allow setting area #872

jvalkeal opened this issue Sep 22, 2023 · 0 comments
Labels
area/components-view Belongs ui view components
Milestone
3.2.0-M2

Comments

@jvalkeal
Copy link
Contributor

TerminalUI uses rootView to draw main content and there is a different for fullscreen vs. nonfullscreen. User should have control over used rectangle are. For fullscreen it's usually terminal size, but nonfullscreen is more complicated as user may want to limit width and definitely use height which works well with current rootView.
@jvalkeal jvalkeal added the area/components-view Belongs ui view components label Sep 22, 2023
@jvalkeal jvalkeal added this to the 3.2.0-M2 milestone Sep 22, 2023
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Sep 22, 2023
@jvalkeal
TerminalUI can define rootView rect
15c5361 
- Add functions to calculate Rectangle for fullscreen/nonfullscreen modes.
- Fixes for rendering so that nonfullscreen works better with views.
- Add some basic samples
- isEmpty method for Rectangle
- Fixes spring-projects#872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/components-view Belongs ui view components
Projects
None yet
Milestone
3.2.0-M2
Development

No branches or pull requests
1 participant
@jvalkeal