Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab completion may fail with lazy initialization #902

Closed
icodening opened this issue Nov 2, 2023 · 2 comments · Fixed by #903
Closed

Tab completion may fail with lazy initialization #902

icodening opened this issue Nov 2, 2023 · 2 comments · Fixed by #903
Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch branch/3.1.x Issue for a branch for/backport For backporting type/bug Is a bug report

Comments

@icodening
Copy link
Contributor

tab-completion fails when spring.main.lazy-initialization=true, and will not found ValueProvider

spring.main.lazy-initialization=true

image

spring.main.lazy-initialization=false

image
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Nov 2, 2023
@icodening icodening mentioned this issue Nov 2, 2023
Merged
@jvalkeal
Copy link
Contributor

jvalkeal commented Nov 4, 2023

I'll see where the PR should be backported.

@jvalkeal jvalkeal changed the title tab-completion fails when spring.main.lazy-initialization=true Tab completion may fail with lazy initialization Nov 6, 2023
@jvalkeal jvalkeal added type/bug Is a bug report for/backport For backporting branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch branch/3.1.x Issue for a branch and removed status/need-triage Team needs to triage and take a first look labels Nov 6, 2023
This was referenced Nov 6, 2023
Closed
Closed
Closed
@jvalkeal
Copy link
Contributor

jvalkeal commented Nov 6, 2023

There's some tech dept in old code which ultimately caused this. PR should be a good short term fix. I'll create new issues to change how this part of a completion should behave.

jvalkeal pushed a commit that referenced this issue Nov 6, 2023
@icodening @jvalkeal
Bugfix: Tab-completion fails
3e80d8d 
- Backport #902
- Fixes #920
jvalkeal pushed a commit that referenced this issue Nov 6, 2023
@icodening @jvalkeal
Bugfix: Tab-completion fails
e2307f3 
- Backport #902
- Fixes #918
jvalkeal added a commit that referenced this issue Nov 6, 2023
@jvalkeal
Bugfix: Tab-completion fails
48aa63f 
- Backport #902
- Fixes #919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch branch/3.1.x Issue for a branch for/backport For backporting type/bug Is a bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: Tab-completion fails icodening/spring-shell
2 participants
@jvalkeal @icodening