Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use string array in ShellRunner #1061

Merged
merged 1 commit into from
May 2, 2024
Merged

Use string array in ShellRunner #1061

merged 1 commit into from
May 2, 2024

Conversation

jvalkeal
Copy link
Contributor

@jvalkeal jvalkeal commented May 2, 2024

  • In ShellRunner interface replace use of boot's ApplicationArguments into plain string array.
  • Deprecate old methods with some fallbacks to give time for users to do updates.
  • NonInteractiveShellRunner contains one breaking change due to its public api to set function doing conversion from ApplicationArguments which was potentially used via customizer hooks.
  • Deprecations planned to get removed in 3.4.x.
  • Fixes Use string array in ShellRunner #1057

@jvalkeal
Use string array in ShellRunner
4a30422 
- In ShellRunner interface replace use of boot's ApplicationArguments
  into plain string array.
- Deprecate old methods with some fallbacks to give
  time for users to do updates.
- NonInteractiveShellRunner contains one breaking change due to its
  public api to set function doing conversion from ApplicationArguments
  which was potentially used via customizer hooks.
- Deprecations planned to get removed in 3.4.x.
- Fixes spring-projects#1057
@jvalkeal jvalkeal merged commit 71960e5 into spring-projects:main May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use string array in ShellRunner
1 participant
@jvalkeal